Skip to content

[SDK] fix: Adjust swap summary border styling #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

[SDK] fix: Adjust swap summary border styling #6272

merged 1 commit into from
Feb 17, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 17, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the layout of the Container in the SwapSummary component by modifying its properties and adding a bottom border style.

Detailed summary

  • Changed Container from a single line to a multi-line format for better readability.
  • Added a style prop to Container to include a bottom border with the color from theme.colors.borderColor.
  • Removed top border styling from the WalletRow component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:58am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:58am

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: d0979c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 17, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Feb 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review February 17, 2025 07:50
@joaquim-verges joaquim-verges requested review from a team as code owners February 17, 2025 07:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 413 ms (+84.3% 🔺) 1.4 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 544 ms (+7.68% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 191 ms (+1395.39% 🔺) 303 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 30 ms (+470.92% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 237 ms (+491.96% 🔺) 623 ms

@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.84%. Comparing base (a258e7e) to head (d0979c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ui/ConnectWallet/screens/Buy/swap/SwapSummary.tsx 0.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6272      +/-   ##
==========================================
- Coverage   56.85%   56.84%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       64657    64662       +5     
  Branches     5238     5241       +3     
==========================================
- Hits        36760    36759       -1     
- Misses      27169    27175       +6     
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a258e7e
packages 55.06% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../ui/ConnectWallet/screens/Buy/swap/SwapSummary.tsx 6.48% <0.00%> (-0.32%) ⬇️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 4158a79 into main Feb 17, 2025
34 of 38 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Adjust_swap_summary_border_styling branch February 17, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges